Improve model preview. #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Display the trigger words on model preview images. * Prevents overwriting exiting preview images. Displaying the trigger words does mean writing those to .txt files in the model directories for every model. Doing this is configurable in the settings. There is no notable lag. Trigger-words with non-ascii characters cause a gradio error, so those areexcluded, and listed on the console.
it includes space, but exludes tab, newline or control characters, which isascii() does not.
|
I'm going to test one thing more, see if there's some hyperlink supprt, which could maybe facilitate the copy-paste process. |
|
I like their buttons, but I don't like it's another tab. maybe the .txt files solution is not ideal either, there should just be buttons and that a button press queries the civitai api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Displaying the trigger words does mean writing those to .txt files in the model directories for every model. Doing this is configurable in the settings. There is no notable lag.
Trigger-words with non-ascii characters cause a gradio error, so those areexcluded, and listed on the console.